AbstractFiniteElement #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mscroggs/remove-elements
mscroggs
commented
Sep 12, 2023
Merged
This was referenced Sep 27, 2023
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FiniteElementBaseclass, and renamed it toAbstractFiniteElement(see Decide on consistent naming for Base/Abstract classes #170)legacy/and added warning about deprecation if they're used. FEniCSx now functions without these files but they are used to get Firedrake/TSFC tests to pass. Medium term plan is to move these files to FIAT or FInAT.FiniteElement,SymmetricElementandMixedElementsubclasses ofAbstractFiniteElementto be used in testing. These are not loaded inufl/__init__.pyas they are not intended for use by users.Resolves #160. Close #60. Close #82.
FEniCS/basix#703, FEniCS/ffcx#614, and FEniCS/dolfinx#2784 must be merged alongside this to make FEniCSx tests pass.
firedrakeproject/tsfc#300 and firedrakeproject/firedrake#3122 must be merged once this is merged into the Firedrake fork of UFL.